Skip to content
This repository has been archived by the owner on May 19, 2021. It is now read-only.

Output buffering during buildFrom* functions #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vaind
Copy link

@vaind vaind commented Jul 18, 2016

Improves performance by ~ 20 % if there are a lot of files

see the original pull request #21

@vaind vaind changed the title master Output buffering during buildFrom* functions Jul 18, 2016
@kherge
Copy link
Contributor

kherge commented Jul 27, 2016

I did a quick performance test using Symfony and got the following results:

Before PR:

Building...

real    15m51.610s
user    6m55.666s
sys     7m22.764s

After PR:

Building...

real    16m40.861s
user    7m12.818s
sys     7m40.737s

Could you provide me with your own benchmarks with details on what you built to perform the test?

@vaind
Copy link
Author

vaind commented Aug 15, 2016

I was finally able to test this. The PR improves performance on HDD but you are right, it really does decrease perf. on SSD (or any other fast IO drive, e. g. /tmp mounted in RAM).
As such, I leave the decision whether to pull this up to you.
Moreover, It may be useful to update the documentation and add some recommendation about creating and building a phar on fast drive/storage and than moving it to the target location.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants